SpartanDev: 19/04/21–25/04/21
DevUpdate: Can’t talk gotta BUIDL | DappV2 | SpartanContractsV2
DevUpdate: Can’t talk gotta BUIDL | DappV2 | SpartanContractsV2
Spartan Socials — Twitter
Top Impressions:
Top Engagement:
Top Community Mention:
SpartanSocials — Medium
SpartanSocials — Telegram
GitHub Activity — SpartanContractsV2
- Continued global factor
- Continued mapping-type changes to reduce gas costs
- Add Reserve contract to handle the SPARTA that has been emitted but not yet circulating (contracts that use incentives now draw from here instead of handling the funds themselves)
- Change all router.grantFunds related references to the new Reserve.grantFunds()
- Added synthVault for synth staking / harvest
- Added params for synthVault to change the % claim to reserve and erasToEarn etc
- Added withdraw functionality to synthVault
- Added harvest functionality to synthVault
- Added mappings and helpers to synthVault
- Added automated testing module for synthVault
- Refactor synthVault & Reserve contracts
- Change ‘types’ in Bond & BondVault to reduce gas costs
- BondVault changes
- Extend Bond automated testing
- Added newDao handling throughout to prevent pointing to old addresses when a temporary dao address is in play with migration edge-cases
- Added weight per synth and total per member to avoid any weight-movement-related exploitation (there is min-deposit-time in place too, so this is accounting for very-edge-case)
- Changed harvest() accordingly
- Added helper function for the UI to be able to get member’s last harvest time per synth
- Changes for newDao handling when there is a migration dao address in place
- Change/finalise some mappings inline with UI feedback
GitHub Activity — SpartanDAppV2
- 25 finalised PRs for the week
refactor swap closes #212 by SamusElderg · Pull Request #224 ·…
closes#212 at some point go thru swap page and refactor everything to use inputs Add this suggestion to a batch that…github.com
- Fix doubleSwap estimated output issue
- Simplify input handling
approval closes #223 by SamusElderg · Pull Request #225 · spartan-protocol/SpartanProtocol-DAppV2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes…github.com
- Added multiple-approval handling in the store and component; so the 2nd approval doesn’t overwrite the 1st tokens approval (when handling two unapproved, non-BNB, base assets)
web3 eventListener closes #147 by SamusElderg · Pull Request #227 ·…
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes…github.com
- Add recentTxns event listeners to the dataManager to have it accessible/looping throughout dapp
mobile responsive updates by SamusElderg · Pull Request #235 ·…
mobile responsive updates Add this suggestion to a batch that can be applied as a single commit. This suggestion is…github.com
- Mobile-responsive changes
- part 1 translation by f1ntch · Pull Request #236 · spartan-protocol/SpartanProtocol-DAppV2
fix missing translation import Add this suggestion to a batch that can be applied as a single commit. This suggestion…github.com
- Setup locales/flags and change i18n implementation to use hooks instead
improve APY logic by SamusElderg · Pull Request #238 · spartan-protocol/SpartanProtocol-DAppV2
improve APY logic closes #197github.com
- Improve APY function to handle partial-month data (recent-divis, recent-fees)
Refactor web3 getcontracts #241 by SamusElderg · Pull Request #249 ·…
Edit descriptiongithub.com
- Improve bond components and data-grabs
- Add ‘bonded’ LPs to walletSelect modal
- Add bondClaim functionality
- Begin refactor of all getContract related functions all within web3Contracts.js
Language functionality - wallet select by dancespiele · Pull Request #252 ·…
I translate wallet select to Spanish. The keyword should be always in Camelcase, we need to changes in thatgithub.com
- Add ‘LastHarvest’ timestamp grab for DAO member
- Fix calcSlipAdjustment()
- Make some functions more readable throughout
- Get the lastHarvest
Synth vault actions #243 by SamusElderg · Pull Request #253 ·…
By clicking "Sign up for GitHub", you agree to our terms of service and privacy statement. We'll occasionally send you…github.com
- Added more state checks for wallet to ensure wallet icon is always showing (and only once; no duplicates)
- Fix stuck blank account issue after wallet connected
- Add function to deposit, harvest and withdraw synths in the vault
- Add a bunch of synthVault helpers and mappings
Synth vault functional #242 by SamusElderg · Pull Request #256 ·…
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes…github.com
- Fix wrong icon for SPARTA when BurningSynthToBase
- Changed terminology throughout to ‘stake’
Swap page improvements by SamusElderg · Pull Request #261 · spartan-protocol/SpartanProtocol-DAppV2
closes #260github.com
Final ‘swap’ component changes:
- On clearInput; focus is switched to the 1st input (UX especially for mobile users)
- Clears to placeholder instead of 0 now for the same reason (UX)
- Removed the 3 clearInputs (on no value) as this is handled via ‘0’ being handed on all calc functions instead (this is better for UX especially when the user tries to get rid of the 0 value to start with another number or no number (less than 1 unit starting with a ‘.’)
- Add calc function for USD-value (internally derived) rate-slip between the two assets
- Change terminology throughout (‘input’ to ‘sell’ etc)
- make the txnDetails values rounded to 6 decimals and make the Cols auto for the descriptor + the rest of the Row for the actual txnDetail Col (repeated as seen throughout all areas)
- Fix alignments
Approval make more simple #262 by SamusElderg · Pull Request #264 ·…
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes…github.com
- Simplify allowance/approval component
- Only show if required; hide when completed
- Fixed some alignment and sizing issues
Wallet fixed postion with scroll by f1ntch · Pull Request #271 ·…
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes…github.com
- WalletSelect modal now fixed on screen (doesn't jump around depending on it’s height)
- Added scroll to the assetlist
- General cleanup
SynthVault prep for next phase by SamusElderg · Pull Request #272 ·…
Resume this page after next contract deploy closes#268 Add this suggestion to a batch that can be applied as a single…github.com
- Setup store etc ready for next synthVault deploy
Issue#265 liquidity UI by f1ntch · Pull Request #274 · spartan-protocol/SpartanProtocol-DAppV2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes…github.com
- Get liquidity UI to the next stage & ready for final functionality changes
Contributor’s Focus
SpartanContracts
- SynthVault V1
- Lend V1
- LendRouter V1
Spartan DAppV1
- Finalise migration-UI
Spartan DAppV2
- Continue DAppV2 improvements
- Test start-to-finish migration from testnet V1 to testnet V2 (within UI)
- Refactor DataManager & code throughout
- Finalise Liq page
SpartanSite
- DAO page
- Lending page
- FAQ page
Other Focuses
- Video & text guides
- Community forum
Community Contribution
Spartan Protocol is at its core, a community-driven and led project. In this vein, the more contributors the better. There is a great opportunity for community members to contribute by making LP reward analysis tools, etc.
Recently, community members have been graciously funnelling in to contribute to explainer articles, ideas and even $SPARTA donations to support the growth of the platform.
Engage with the community and contributors
Where to find out about all the latest updates or suggest improvements — get involved.
- Github: https://github.com/spartan-protocol
- Medium: https://medium.com/spartanprotocol
- Twitter: https://twitter.com/spartanprotocol
- Telegram Community: https://t.me/spartanprotocolorg
- Telegram Announcements: https://t.me/spartanprotocolann
- Telegram Bounties Channel: https://t.me/SpartanProtocolBounties
GitHub list of bounties available
spartan-protocol/spartan-site
New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its…github.com
Reach out on telegram to get involved: https://t.me/SpartanProtocolBounties